git-hulk commented on code in PR #2845:
URL: https://github.com/apache/kvrocks/pull/2845#discussion_r2048258903
##########
src/storage/storage.cc:
##########
@@ -794,9 +794,7 @@ StatusOr<int> Storage::IngestSST(const std::string
&sst_dir, const rocksdb::Inge
std::vector<std::string> cf_names;
for (const auto &cf : ColumnFamilyConfigs::ListAllColumnFamilies()) {
cf_names.emplace_back(cf.Name());
- }
- for (const auto &cf_name : cf_names) {
- cf_files[cf_name] = std::vector<std::string>();
+ cf_files[cf.Name()] = std::vector<std::string>();
Review Comment:
What @PragmaTwice should be is that we don't need to initialize the empty
vector for the map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
