caipengbo commented on code in PR #2845:
URL: https://github.com/apache/kvrocks/pull/2845#discussion_r2048105708
##########
src/storage/storage.cc:
##########
@@ -769,6 +770,98 @@ rocksdb::Status Storage::FlushScripts(engine::Context
&ctx, const rocksdb::Write
return Write(ctx, options, batch->GetWriteBatch());
}
+StatusOr<int> Storage::IngestSST(const std::string &sst_dir, const
rocksdb::IngestExternalFileOptions &ingest_options) {
+ std::vector<std::string> sst_files;
+ DIR *dir = opendir(sst_dir.c_str());
Review Comment:
1. RocksDB's API is more portable
2. The overall code style is more unified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
