SharonIV0x86 commented on code in PR #2849:
URL: https://github.com/apache/kvrocks/pull/2849#discussion_r2071648306
##########
src/commands/cmd_tdigest.cc:
##########
@@ -242,11 +242,47 @@ class CommandTDigestMax : public CommandTDigestMinMax {
public:
CommandTDigestMax() : CommandTDigestMinMax(false) {}
};
+class CommandTDigestQuantile : public Commander {
+ Status Parse(const std::vector<std::string> &args) override {
+ key_name_ = args[1];
+ values_.reserve(args.size() - 2);
+ for (size_t i = 2; i < args.size(); i++) {
+ auto value = ParseFloat(args[i]);
+ if (!value) {
+ return {Status::RedisParseErr, errValueIsNotFloat};
+ }
+ values_.push_back(*value);
+ }
+ return Status::OK();
+ }
+ Status Execute(engine::Context &ctx, Server *srv, Connection *conn,
std::string *output) override {
+ TDigest tdigest(srv->storage, conn->GetNamespace());
+ TDigestQuantitleResult result;
+ auto s = tdigest.Quantile(ctx, key_name_, values_, &result);
Review Comment:
Sorry for delayed response i was busy with an event. About this yes, i have
added this check locally but i will just push it in sometime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
