SharonIV0x86 commented on PR #2849: URL: https://github.com/apache/kvrocks/pull/2849#issuecomment-2847280659
> Hi @SharonIV0x86 , > > Sorry for delay review. 😊 > > For the lock of quantile merging, I have checked the lock in `redis_connection.cc` and `Database::AppendNamespacePrefix`. > > They lock the same key for same tdigest user key. > > So, it is safe to lock the [`ns_key`](https://github.com/apache/kvrocks/blob/009a1bd80bdde88c091a69aca1539be0f58d2658/src/types/redis_tdigest.cc#L190-L193). > > https://github.com/apache/kvrocks/blob/009a1bd80bdde88c091a69aca1539be0f58d2658/src/server/redis_connection.cc#L521 > > https://github.com/apache/kvrocks/blob/009a1bd80bdde88c091a69aca1539be0f58d2658/src/storage/redis_db.cc#L520-L522 > > Best Regards, Edward Understood. So the current logic is fine and we can most probably refactor it into a function later on #2907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
