greatsharp commented on code in PR #2954:
URL: https://github.com/apache/kvrocks/pull/2954#discussion_r2151049001


##########
src/server/server.cc:
##########
@@ -2126,3 +2127,110 @@ AuthResult Server::AuthenticateUser(const std::string 
&user_password, std::strin
   *ns = kDefaultNamespace;
   return AuthResult::IS_ADMIN;
 }
+
+std::string Server::GetSlotStats(const std::vector<SlotRange> &slot_ranges) {

Review Comment:
   > Can also return the `last_scan_time_secs` as well? so that we can identify 
if the scan operation is in progress.
   
   
![Snipaste_2025-06-16_23-44-13](https://github.com/user-attachments/assets/fd1fd375-f0f1-4307-bafc-be83c2a01664)
   



##########
src/server/server.cc:
##########
@@ -2126,3 +2127,110 @@ AuthResult Server::AuthenticateUser(const std::string 
&user_password, std::strin
   *ns = kDefaultNamespace;
   return AuthResult::IS_ADMIN;
 }
+
+std::string Server::GetSlotStats(const std::vector<SlotRange> &slot_ranges) {

Review Comment:
   git push authorization failed suddenly yesteray, commit latter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to