greatsharp commented on PR #2954: URL: https://github.com/apache/kvrocks/pull/2954#issuecomment-2994606200
> > > > LGTM, one more comment: `GetSlotStats` should also only allow to get/scan the slot that belongs to the node. And can clean the old stats if the slot has been moved. cc @PragmaTwice > > > > > > > > > How do you know whether there is duplicate dirty data on node or not if you cannot scan the slots which was migrated out? > > > > > > In my opinion, keep each command clear and accurate > > You can check this when calling `GetSlotStats`, it would be easy to know which slots no longer belong to this node. Do you mean we can put the scan and clear process all in one GetSlotStats method? Could you give more details or setsp of it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
