PragmaTwice commented on code in PR #3087:
URL: https://github.com/apache/kvrocks/pull/3087#discussion_r2247272200
##########
src/cluster/replication.h:
##########
@@ -64,8 +65,13 @@ using FetchFileCallback = std::function<void(const
std::string &, uint32_t)>;
class FeedSlaveThread {
public:
- explicit FeedSlaveThread(Server *srv, redis::Connection *conn,
rocksdb::SequenceNumber next_repl_seq)
- : srv_(srv), conn_(conn), next_repl_seq_(next_repl_seq), req_(srv) {}
+ FeedSlaveThread(Server *srv, redis::Connection *conn,
rocksdb::SequenceNumber next_repl_seq)
+ : srv_(srv),
+ conn_(conn),
+ next_repl_seq_(next_repl_seq),
+ req_(srv),
+ max_delay_bytes_(srv->GetConfig()->max_replication_delay_bytes),
+ max_delay_updates_(srv->GetConfig()->max_replication_delay_updates) {}
Review Comment:
Need to move it to `replication.cc` to avoid incomplete type.
##########
src/cluster/replication.h:
##########
@@ -36,6 +36,7 @@
#include "io_util.h"
#include "rocksdb/write_batch.h"
#include "server/redis_connection.h"
+#include "server/server.h"
Review Comment:
Remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
