PragmaTwice commented on code in PR #3087:
URL: https://github.com/apache/kvrocks/pull/3087#discussion_r2247273389


##########
src/cluster/replication.h:
##########
@@ -87,8 +93,9 @@ class FeedSlaveThread {
   redis::Request req_;
   std::atomic<rocksdb::SequenceNumber> ack_seq_ = 0;
 
-  static const size_t kMaxDelayUpdates = 16;
-  static const size_t kMaxDelayBytes = 16 * 1024;
+  // Configurable delay limits
+  size_t max_delay_bytes_ = 16 * 1024;
+  size_t max_delay_updates_ = 16;

Review Comment:
   ```suggestion
     size_t max_delay_bytes_;
     size_t max_delay_updates_;
   ```
   
   Default value seems not so useful here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to