donghao526 commented on PR #3249: URL: https://github.com/apache/kvrocks/pull/3249#issuecomment-3527349962
Hi @LindaSummer Thank you for taking the time to review my code😊. I have made changes. 1. Use a template to dispatch the CommandTDigestRevRank and CommandTDigestRank commands. 2. Use a constexpr to enable the reverse value to be evaluated at compile time within TDigestRankImpl. 3. Add a case with more different or same and unordered inputs to have a comprehensive integration test. Best Regards, Hao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
