LindaSummer commented on code in PR #3249: URL: https://github.com/apache/kvrocks/pull/3249#discussion_r2527697360
########## src/types/redis_tdigest.cc: ########## @@ -244,7 +300,7 @@ rocksdb::Status TDigest::RevRank(engine::Context& ctx, const Slice& digest_name, } auto dump_centroids = DummyCentroids(metadata, centroids); - auto status = TDigestRevRank(dump_centroids, inputs, result); + auto status = TDigestRank(dump_centroids, inputs, reverse, result); Review Comment: We could make all the flags for `reverse` a compile-time argument. It's an optional suggestion. We could do it in a future refactor.😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
