PragmaTwice commented on code in PR #3268:
URL: https://github.com/apache/kvrocks/pull/3268#discussion_r2556218342
##########
src/types/redis_tdigest.h:
##########
@@ -132,4 +228,38 @@ class TDigest : public SubKeyScanner {
Centroid* centroid) const;
};
+template <bool Reverse>
+rocksdb::Status TDigest::Rank(engine::Context& ctx, const Slice& digest_name,
const std::vector<double>& inputs,
Review Comment:
I think maybe we can just expose two non-template function TDigest::Rank and
TDigest::RevRank so that we can put the definition of this function into the
.cc file instead of header?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
