LindaSummer commented on code in PR #3268:
URL: https://github.com/apache/kvrocks/pull/3268#discussion_r2585220581
##########
src/types/redis_tdigest.h:
##########
@@ -33,6 +33,93 @@
#include "tdigest.h"
namespace redis {
+
+namespace detail {
Review Comment:
To reduce conflict with other symbols in `redis` namespace, it would be
better guarded by a namespace like `tdigest`.
After we refactor this in cc file, this could just be in an anonymous
namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
