git-hulk commented on PR #3269: URL: https://github.com/apache/kvrocks/pull/3269#issuecomment-3573619705
@tejaslodayadd Thanks for your contribution. I just had a glance at this PR and have two questions about the design: - When would the size in metadata be updated? It seems the size won't be corrected after the compaction. - Should we also take care of the HSCAN command? Let's filter out the expired fields. From my personal perspective, it's acceptable to sacrifice the short-term correctness of a command like HLEN to improve performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
