ltagliamonte-dd commented on PR #3269:
URL: https://github.com/apache/kvrocks/pull/3269#issuecomment-3604159031
@git-hulk @PragmaTwice FYI I'm going to help @tejaslodayadd with this PR.
I've addressed few of the comments you folks left.
I'm currently debating how to proceed with the compaction size/problem.
during compaction of the default CF we can't update the metadata CF (where
the hash size is), so i think we could go for a lazy repair pattern:
- during compactions if a field is expired we just update it's value to a
STUB value (0xFE) so we immediately reclaim the disk space
- during read operations like HGET, HGETALL, HSCAN we do a
synchronous/asynchronous Repair:
- Create an Atomic WriteBatch.
- Delete the key from defaultCF.
- Update/Merge the count in metadataCF.
- Commit.
What do you folks think about this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
