donghao526 commented on code in PR #3268:
URL: https://github.com/apache/kvrocks/pull/3268#discussion_r2592642653
##########
src/types/redis_tdigest.h:
##########
@@ -33,6 +33,93 @@
#include "tdigest.h"
namespace redis {
+
+namespace detail {
Review Comment:
Hi @LindaSummer
1. I have exposed two non-template functions, TDigest::Rank and
TDigest::RevRank, and placed their definitions in the .cc file.
2. I have placed the GetCBeginIter and GetCEndIter functions inside an
anonymous namespace.
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
