lauk20 commented on code in PR #3450:
URL: https://github.com/apache/kvrocks/pull/3450#discussion_r3221433734
##########
src/storage/redis_metadata.cc:
##########
@@ -566,6 +568,8 @@ rocksdb::Status TimeSeriesMetadata::Decode(Slice *input) {
GetSizedString(input, &source_key_slice);
source_key = source_key_slice.ToString();
GetFixed64(input, &last_timestamp);
+ GetFixed64(input, &ignore_max_time_diff);
Review Comment:
@jihuayu I have committed the backward compatibility fixes.
I do not believe that forward compatibility is supported. It may be
difficult given that if new metadata is written on a newer version and the user
rolls back to an older version, the metadata for `ignore_max_time_diff` and
`ignore_max_val_diff` will still already be written on disk in RocksDB. I am
unsure if there is any parts of the codebase that depends on the metadata
format to be formatted strictly based on the existing metadata format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
