jihuayu commented on code in PR #3450:
URL: https://github.com/apache/kvrocks/pull/3450#discussion_r3224877021
##########
tests/gocase/unit/type/timeseries/timeseries_test.go:
##########
@@ -201,6 +201,24 @@ func testTimeSeries(t *testing.T, configs
util.KvrocksServerConfigs) {
require.ErrorContains(t, rdb.Do(ctx, "ts.add", key, "1000",
"13.4").Err(), "update is not supported when DUPLICATE_POLICY is set to BLOCK
mode")
})
+ t.Run("TS.ADD Ignore Option", func(t *testing.T) {
Review Comment:
The test cases are missing a significant number of negative scenarios where
parameters fail to take effect. Could you please add them?
##########
src/types/redis_timeseries.h:
##########
@@ -257,8 +259,7 @@ enum class TSAlterMode : uint8_t {
RETENTION = 1,
CHUNK_SIZE = 1 << 1,
DUPLICATE_POLICY = 1 << 2,
- IGNORE = 1 << 3,
- LABELS = 1 << 4,
+ LABELS = 1 << 3,
Review Comment:
We change the `LABELS ` value. Why we need change it?
You can use comments to indicate that this item is not being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
