nagisa-kunhah commented on PR #3481:
URL: https://github.com/apache/kvrocks/pull/3481#issuecomment-4634627126
Hi, I'm ready for the next round of review. Here's a summary of the
functional changes since last time:
- Aligned the default Cuckoo Filter parameters with RedisBloom
compatibility:
- default BUCKETSIZE is now 2
- default MAXITERATIONS is now 20
- default EXPANSION is now 1
- Normalized CF.RESERVE EXPANSION to the next power of two before storing
it in metadata, matching RedisBloom behavior.
- Preserved EXPANSION 0 as the non-scaling mode.
- Added disk-size support for Cuckoo Filter keys so size-related stats no
longer treat MBbloomCF keys as missing.
I also found that Cuckoo Filter support is still missing in the
command-based migration path. Since Cuckoo Filter pages store fingerprints
instead of the original items, command-based migration cannot reconstruct the
original CF.ADD commands directly. Would it be OK to add migration support in a
separate follow-up PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
