jihuayu commented on code in PR #3481: URL: https://github.com/apache/kvrocks/pull/3481#discussion_r3379551183
########## src/types/redis_cuckoo_chain.h: ########## @@ -30,9 +30,9 @@ class CuckooSubFilter; // Default values for a newly created cuckoo filter. const uint32_t kCFDefaultCapacity = 1024; -const uint8_t kCFDefaultBucketSize = 4; // 4 fingerprints per bucket -const uint16_t kCFDefaultMaxIterations = 500; -const uint16_t kCFDefaultExpansion = 2; +const uint8_t kCFDefaultBucketSize = 2; +const uint16_t kCFDefaultMaxIterations = 20; Review Comment: Is this change intended to align with Redis? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
