kirito632 commented on PR #3502: URL: https://github.com/apache/kvrocks/pull/3502#issuecomment-4649778860
@jihuayu ,While reviewing the stream code for XDELEX, I found two unrelated stream issues: 1. XACK with duplicate IDs may acknowledge the same PEL entry multiple times before the batch is committed, leading to incorrect return values and pending counter updates. 2. XLEN with entry-id filtering on an empty MKSTREAM-created stream can underflow and return UINT64_MAX. These appear independent of XDELEX, so I plan to handle them separately to keep the current PR focused.Do you think this approach is acceptable, or should I address them within the current PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
