kirito632 commented on PR #3502: URL: https://github.com/apache/kvrocks/pull/3502#issuecomment-4689250902
@jihuayu , The CI is green now, but SonarCloud is still failing because Coverage on New Code is 40.5% (required >= 50%). After checking the report, most uncovered lines are in: * src/storage/batch_extractor.cc * src/commands/cmd_stream.cc The stream command behavior itself is already covered by the newly added Go tests, but Sonar seems to be counting several WriteBatchExtractor paths that are difficult to exercise through command-level tests. I'm considering adding a few focused C++ tests around WriteBatchExtractor to increase coverage. Before doing that, I'd like to confirm whether this is the direction you'd prefer, or if there are other areas you think would benefit more from additional coverage. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
