GitHub user jihuayu edited a comment on the discussion: Proposal: Keyspace Notifications for Kvrocks
Hi @Aetherance. I’ve been thinking about this for the past few days. I think we can reuse the existing WriteBatchLogData mechanism and extend it slightly. That should allow us to preserve accuracy while keeping the additional WAL overhead relatively small. However, please don’t implement both the subscription mechanism and the replication/synchronization logic in a single PR. That would make the PR very large and difficult to review. We should start with a smaller scope and break this larger effort into multiple PRs. In general, a PR with more than about 400 non-test lines of changes is already considered fairly large from a reviewer’s perspective. Larger PRs take substantially more time and effort to review. GitHub link: https://github.com/apache/kvrocks/discussions/3533#discussioncomment-17421066 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
