Aetherance commented on PR #3541: URL: https://github.com/apache/kvrocks/pull/3541#issuecomment-4876710630
> Looks great. I like the code you wrote.看起来很棒。我喜欢你写的代码。 > > Redis keyspace notifications treat `$` as the string command class. Besides `SET`, commands such as `SETEX`/`PSETEX`, `GETSET`, `MSET`, `APPEND`, `INCR*`, and `SETRANGE` also emit string events (`set`, `append`, `incrby`, `setrange`, etc.; `SETEX`/`PSETEX` also emit `expire`). This PR currently only emits notifications for literal `SET`. Is the remaining string command coverage intentionally deferred to a follow-up PR?Redis 键空间通知将 `$` 视为字符串命令类型。除了 `SET` 之外， `SETEX` 、 `PSETEX` 、 `GETSET` 、 `MSET` 、 `APPEND` 、 `INCR*` 和 `SETRANGE` 等命令也会触发字符串相关的事件（如 `set` 、 `append` 、 `incrby` 、 `setrange` 等； `SETEX` / `PSETEX` 也会触发 `expire` 相关事件）。目前的这个 PR 仅针对 `SET` 这种命令类型发出通知。至于其他字符串命令的处理，是否打算在后续的 PR 中再处理呢？ @jihuayu Yes, that is intentionally deferred to follow-up PRs. This PR focuses on the minimal `SET` and `DEL` notification support first. Adding the rest of the string command coverage in the same PR would make the change much larger and harder to review, so I intentionally kept the scope limited here. I’m happy to cover the remaining string commands such as `SETEX`/`PSETEX`, `GETSET`, `MSET`, `APPEND`, `INCR*`, and `SETRANGE` in follow-up PRs once the basic notification path is accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
