git-hulk commented on PR #3541: URL: https://github.com/apache/kvrocks/pull/3541#issuecomment-4881555720
@Aetherance Thanks for your effort and reply. > For example, a conditional SET may return OK without actually writing the key, such as SET ... NX when the key already exists. DEL also needs to know the exact keys that were actually removed; cases like DEL k k k must not emit duplicate notifications. After iterating on the current implementation and proposal, I understood your intention. And yes, it's a bit tricky to depend on rocksdb WAL to achieve this feature. For the implementation, we can check config flags, channel names, Pub/Sub publishing in one place like `srv->NotifyKeyspaceEvent`. So we can just add one line for each place where we need to emit the event. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
