ASF GitHub Bot commented on KYLIN-3280:

xingpeng1 closed pull request #113: KYLIN-3280
URL: https://github.com/apache/kylin/pull/113

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/webapp/app/partials/cubes/cube_delete_segment.html 
index 8500f3f7a9..93356eeeae 100644
--- a/webapp/app/partials/cubes/cube_delete_segment.html
+++ b/webapp/app/partials/cubes/cube_delete_segment.html
@@ -83,7 +83,7 @@ <h4 tooltip="refresh">CUBE SEGMENT DELETE CONFIRM</h4>
     <div class="modal-footer">
         <button class="btn btn-primary" ng-click="cancel()">Close</button>
-        <button class="btn btn-success" ng-click="deleteSegment()">Delete
+        <button class="btn btn-success" ng-click="deleteSegment()" 
ng-disabled="!(cube.segments && cube.segments.length > 0)">Delete
\ No newline at end of file


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> The delete button should not be enabled without any segment in cube segment 
> delete confirm dialog
> -------------------------------------------------------------------------------------------------
>                 Key: KYLIN-3280
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3280
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>    Affects Versions: v2.4.0
>            Reporter: Peng Xing
>            Assignee: Peng Xing
>            Priority: Minor
>         Attachments: delete_segment.png
> 1. Open cube list, choose one disabled cube, then select 'Delete Segment';
> 2. The Delete button is enabled without any segment, and if you click it, it 
> has no prompt.
> please see the attachment picture.

This message was sent by Atlassian JIRA

Reply via email to