[
https://issues.apache.org/jira/browse/KYLIN-3280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394773#comment-16394773
]
ASF GitHub Bot commented on KYLIN-3280:
---------------------------------------
codecov-io commented on issue #113: KYLIN-3280
URL: https://github.com/apache/kylin/pull/113#issuecomment-371697041
# [Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=h1) Report
> Merging [#113](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/06f497eb603134a6b0ddbfd88739ccaddab007fb?src=pr&el=desc)
will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #113 +/- ##
============================================
- Coverage 21.86% 21.58% -0.29%
+ Complexity 3887 3854 -33
============================================
Files 996 996
Lines 59992 59964 -28
Branches 8665 8661 -4
============================================
- Hits 13119 12941 -178
- Misses 45653 45826 +173
+ Partials 1220 1197 -23
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...a/org/apache/kylin/rest/job/StorageCleanupJob.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL1N0b3JhZ2VDbGVhbnVwSm9iLmphdmE=)
| `0% <0%> (-65.06%)` | `0% <0%> (-24%)` | |
|
[...pache/kylin/rest/job/StorageCleanJobHbaseUtil.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvam9iL1N0b3JhZ2VDbGVhbkpvYkhiYXNlVXRpbC5qYXZh)
| `0% <0%> (-60.66%)` | `0% <0%> (-7%)` | |
|
[...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==)
| `35.71% <0%> (-4.77%)` | `5% <0%> (-1%)` | |
|
[...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==)
| `13.08% <0%> (-4.72%)` | `6% <0%> (ø)` | |
|
[.../apache/kylin/common/persistence/ResourceTool.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVRvb2wuamF2YQ==)
| `8.14% <0%> (-1.51%)` | `5% <0%> (ø)` | |
|
[...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=)
| `54.72% <0%> (-1%)` | `21% <0%> (ø)` | |
|
[...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
| `81.74% <0%> (-0.8%)` | `17% <0%> (-1%)` | |
|
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
| `64.56% <0%> (-0.79%)` | `0% <0%> (ø)` | |
|
[...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh)
| `46.26% <0%> (-0.37%)` | `9% <0%> (ø)` | |
|
[...va/org/apache/kylin/rest/service/AdminService.java](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9BZG1pblNlcnZpY2UuamF2YQ==)
| `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [1
more](https://codecov.io/gh/apache/kylin/pull/113/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=footer). Last
update
[06f497e...117edef](https://codecov.io/gh/apache/kylin/pull/113?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> The delete button should not be enabled without any segment in cube segment
> delete confirm dialog
> -------------------------------------------------------------------------------------------------
>
> Key: KYLIN-3280
> URL: https://issues.apache.org/jira/browse/KYLIN-3280
> Project: Kylin
> Issue Type: Bug
> Components: Web
> Affects Versions: v2.4.0
> Reporter: Peng Xing
> Assignee: Peng Xing
> Priority: Minor
> Attachments: delete_segment.png
>
>
> 1. Open cube list, choose one disabled cube, then select 'Delete Segment';
> 2. The Delete button is enabled without any segment, and if you click it, it
> has no prompt.
> please see the attachment picture.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
