[jira] [Commented] (KYLIN-3293) FixedLenHexDimEnc return a wrong code length leads to cut bytes error.

Fri, 16 Mar 2018 07:45:54 -0700 

    [ 
https://issues.apache.org/jira/browse/KYLIN-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401988#comment-16401988
 ] 

ASF GitHub Bot commented on KYLIN-3293:
---------------------------------------

codecov-io commented on issue #117: KYLIN-3293, fix FixedLenHexDimEnc.java 
return a wrong code length lea…
URL: https://github.com/apache/kylin/pull/117#issuecomment-373735030
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=h1) Report
   > Merging [#117](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/cf6d76d2dd5c96d3979481fe4d7ca69bbb626b30?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `55.55%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/117/graphs/tree.svg?width=650&src=pr&token=JawVgbgsVo&height=150)](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master     #117      +/-   ##
   ============================================
   + Coverage     21.85%   21.85%   +<.01%     
   - Complexity     3884     3889       +5     
   ============================================
     Files           996      996              
     Lines         59999    59999              
     Branches       8666     8666              
   ============================================
   + Hits          13112    13114       +2     
   + Misses        45667    45664       -3     
   - Partials       1220     1221       +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[.../org/apache/kylin/dimension/FixedLenHexDimEnc.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vZGltZW5zaW9uL0ZpeGVkTGVuSGV4RGltRW5jLmphdmE=)
 | `83.46% <55.55%> (ø)` | `23 <6> (+1)` | :arrow_up: |
   | 
[...rg/apache/kylin/storage/hbase/HBaseConnection.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZUNvbm5lY3Rpb24uamF2YQ==)
 | `13.08% <0%> (-4.72%)` | `6% <0%> (ø)` | |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `69.3% <0%> (-0.92%)` | `7% <0%> (ø)` | |
   | 
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
 | `16.18% <0%> (+1.22%)` | `37% <0%> (+2%)` | :arrow_up: |
   | 
[...g/apache/kylin/source/datagen/ColumnGenerator.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc291cmNlL2RhdGFnZW4vQ29sdW1uR2VuZXJhdG9yLmphdmE=)
 | `72.29% <0%> (+1.35%)` | `8% <0%> (ø)` | :arrow_down: |
   | 
[...main/java/org/apache/kylin/common/KylinConfig.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZy5qYXZh)
 | `32.35% <0%> (+1.68%)` | `21% <0%> (+1%)` | :arrow_up: |
   | 
[...e/kylin/common/KylinConfigCannotInitException.java](https://codecov.io/gh/apache/kylin/pull/117/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Nhbm5vdEluaXRFeGNlcHRpb24uamF2YQ==)
 | `100% <0%> (+100%)` | `1% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=footer). Last 
update 
[cf6d76d...1d2d804](https://codecov.io/gh/apache/kylin/pull/117?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> FixedLenHexDimEnc return a wrong code length leads to cut bytes error.
> ----------------------------------------------------------------------
>
>                 Key: KYLIN-3293
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3293
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: jiatao.tao
>            Assignee: jiatao.tao
>            Priority: Major
>
> FixedLenHexDimEnc lost its byteLen when deserializing, so in  
> GTRecord#loadColumnsFromColumnBlocks, the byte after cutting are wrong.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to