[
https://issues.apache.org/jira/browse/KYLIN-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16412995#comment-16412995
]
ASF GitHub Bot commented on KYLIN-3293:
---------------------------------------
codecov-io commented on issue #123: KYLIN-3293, fix FixedLenHexDimEnc that
return a wrong code length lea…
URL: https://github.com/apache/kylin/pull/123#issuecomment-375964107
# [Codecov](https://codecov.io/gh/apache/kylin/pull/123?src=pr&el=h1) Report
> Merging [#123](https://codecov.io/gh/apache/kylin/pull/123?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/a7a0baa319c8f609be0142e7098141f518b972fb?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/123?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #123 +/- ##
============================================
- Coverage 21.83% 21.83% -0.01%
Complexity 3886 3886
============================================
Files 999 999
Lines 60067 60069 +2
Branches 8675 8675
============================================
- Hits 13117 13115 -2
- Misses 45729 45732 +3
- Partials 1221 1222 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/123?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...he/kylin/cube/gridtable/TrimmedCubeCodeSystem.java](https://codecov.io/gh/apache/kylin/pull/123/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2dyaWR0YWJsZS9UcmltbWVkQ3ViZUNvZGVTeXN0ZW0uamF2YQ==)
| `62% <ø> (ø)` | `5 <0> (ø)` | :arrow_down: |
|
[.../org/apache/kylin/dimension/FixedLenHexDimEnc.java](https://codecov.io/gh/apache/kylin/pull/123/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vZGltZW5zaW9uL0ZpeGVkTGVuSGV4RGltRW5jLmphdmE=)
| `82.17% <0%> (-1.3%)` | `22 <0> (ø)` | |
|
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/123/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
| `64.56% <0%> (-0.79%)` | `0% <0%> (ø)` | |
|
[...g/apache/kylin/metadata/cachesync/Broadcaster.java](https://codecov.io/gh/apache/kylin/pull/123/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvY2FjaGVzeW5jL0Jyb2FkY2FzdGVyLmphdmE=)
| `55.22% <0%> (-0.5%)` | `21% <0%> (ø)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/123?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/123?src=pr&el=footer). Last
update
[a7a0baa...1e5c7a6](https://codecov.io/gh/apache/kylin/pull/123?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> FixedLenHexDimEnc return a wrong code length leads to cut bytes error.
> ----------------------------------------------------------------------
>
> Key: KYLIN-3293
> URL: https://issues.apache.org/jira/browse/KYLIN-3293
> Project: Kylin
> Issue Type: Bug
> Reporter: jiatao.tao
> Assignee: jiatao.tao
> Priority: Major
>
> FixedLenHexDimEnc lost its byteLen when deserializing, so in
> GTRecord#loadColumnsFromColumnBlocks, the byte after cutting are wrong.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
