[jira] [Commented] (KYLIN-1948) IntegerDimEnc, does not encode -1 correctly

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KYLIN-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507811#comment-16507811
 ] 

ASF GitHub Bot commented on KYLIN-1948:
---------------------------------------

codecov-io commented on issue #153: KYLIN-1948, add test to cover the case.
URL: https://github.com/apache/kylin/pull/153#issuecomment-396165401
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/153?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@f6b1dfb`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/153/graphs/tree.svg?height=150&width=650&token=JawVgbgsVo&src=pr)](https://codecov.io/gh/apache/kylin/pull/153?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #153   +/-   ##
   =========================================
     Coverage          ?   22.15%           
     Complexity        ?     4022           
   =========================================
     Files             ?     1012           
     Lines             ?    61207           
     Branches          ?     8768           
   =========================================
     Hits              ?    13561           
     Misses            ?    46408           
     Partials          ?     1238
   ```
   
   
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/153?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/153?src=pr&el=footer). Last 
update 
[f6b1dfb...6140851](https://codecov.io/gh/apache/kylin/pull/153?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> IntegerDimEnc, does not encode -1 correctly
> -------------------------------------------
>
>                 Key: KYLIN-1948
>                 URL: https://issues.apache.org/jira/browse/KYLIN-1948
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: liyang
>            Assignee: jiatao.tao
>            Priority: Major
>             Fix For: v2.4.0
>
>
> The code for -1 is all 0xff, which is the code for NULL. Need a fix, since -1 
> is a common value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)