[
https://issues.apache.org/jira/browse/KYLIN-1948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509050#comment-16509050
]
ASF GitHub Bot commented on KYLIN-1948:
---------------------------------------
shaofengshi closed pull request #153: KYLIN-1948, add test to cover the case.
URL: https://github.com/apache/kylin/pull/153
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-metadata/src/test/java/org/apache/kylin/dimension/IntegerDimEncTest.java
b/core-metadata/src/test/java/org/apache/kylin/dimension/IntegerDimEncTest.java
index 039e05637b..d731a87cf8 100644
---
a/core-metadata/src/test/java/org/apache/kylin/dimension/IntegerDimEncTest.java
+++
b/core-metadata/src/test/java/org/apache/kylin/dimension/IntegerDimEncTest.java
@@ -109,6 +109,15 @@ public void testNull() {
}
}
+ @Test
+ // For JIRA: KYLIN-1948
+ public void testEncodeDecodeMinusOne() {
+ for (int i = 1; i < 9; i++) {
+ IntegerDimEnc enc = new IntegerDimEnc(i);
+ testEncodeDecode(enc, -1);
+ }
+ }
+
@Test
public void testEncodeDecode() {
for (int i = 1; i <= successValue.size(); i++) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> IntegerDimEnc, does not encode -1 correctly
> -------------------------------------------
>
> Key: KYLIN-1948
> URL: https://issues.apache.org/jira/browse/KYLIN-1948
> Project: Kylin
> Issue Type: Bug
> Reporter: liyang
> Assignee: jiatao.tao
> Priority: Major
> Fix For: v2.4.0
>
>
> The code for -1 is all 0xff, which is the code for NULL. Need a fix, since -1
> is a common value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
