[ 
https://issues.apache.org/jira/browse/KYLIN-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577897#comment-16577897
 ] 

ASF GitHub Bot commented on KYLIN-3317:
---------------------------------------

asfgit commented on issue #197: KYLIN-3317, replace UUID.randomUUID with new 
UUID(ThreadLocalRandom.current().nextLong(), 
ThreadLocalRandom.current().nextLong())
URL: https://github.com/apache/kylin/pull/197#issuecomment-412426659
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Replace UUID.randomUUID with deterministic PRNG
> -----------------------------------------------
>
>                 Key: KYLIN-3317
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3317
>             Project: Kylin
>          Issue Type: Task
>          Components: Security
>            Reporter: Ted Yu
>            Assignee: jiatao.tao
>            Priority: Major
>             Fix For: v2.5.0
>
>
> Currently UUID.randomUUID is called in various places in the code base.
> * It is non-deterministic.
> * It uses a single secure random for UUID generation. This uses a single JVM 
> wide lock, and this can lead to lock contention and other performance 
> problems.
> We should move to something that is deterministic by using seeded PRNGs
> {code}
> new UUID(ThreadLocalRandom.current().nextLong(), 
> ThreadLocalRandom.current().nextLong())
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to