[
https://issues.apache.org/jira/browse/KYLIN-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577913#comment-16577913
]
ASF GitHub Bot commented on KYLIN-3317:
---------------------------------------
codecov-io commented on issue #197: KYLIN-3317, replace UUID.randomUUID with
new UUID(ThreadLocalRandom.current().nextLong(),
ThreadLocalRandom.current().nextLong())
URL: https://github.com/apache/kylin/pull/197#issuecomment-412431045
# [Codecov](https://codecov.io/gh/apache/kylin/pull/197?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@ddfed27`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `29.62%`.
[](https://codecov.io/gh/apache/kylin/pull/197?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #197 +/- ##
=========================================
Coverage ? 21.06%
Complexity ? 4292
=========================================
Files ? 1070
Lines ? 67825
Branches ? 9837
=========================================
Hits ? 14285
Misses ? 52169
Partials ? 1371
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/197?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...che/kylin/rest/controller/StreamingController.java](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9TdHJlYW1pbmdDb250cm9sbGVyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...e/kylin/source/kafka/util/KafkaSampleProducer.java](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree#diff-c291cmNlLWthZmthL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zb3VyY2Uva2Fma2EvdXRpbC9LYWZrYVNhbXBsZVByb2R1Y2VyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...apache/kylin/storage/hbase/HBaseResourceStore.java](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9IQmFzZVJlc291cmNlU3RvcmUuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[.../apache/kylin/rest/controller/ModelController.java](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9Nb2RlbENvbnRyb2xsZXIuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...kylin/storage/hbase/lookup/HBaseLookupMRSteps.java](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9sb29rdXAvSEJhc2VMb29rdXBNUlN0ZXBzLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...g/apache/kylin/rest/controller/CubeController.java](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9DdWJlQ29udHJvbGxlci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...kylin/common/persistence/RootPersistentEntity.java](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9Sb290UGVyc2lzdGVudEVudGl0eS5qYXZh)
| `20.45% <0%> (ø)` | `4 <0> (?)` | |
|
[...ylin/rest/controller/ExternalFilterController.java](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvY29udHJvbGxlci9FeHRlcm5hbEZpbHRlckNvbnRyb2xsZXIuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...va/org/apache/kylin/rest/service/TableService.java](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9UYWJsZVNlcnZpY2UuamF2YQ==)
| `13.13% <0%> (ø)` | `9 <0> (?)` | |
|
[...apache/kylin/common/persistence/ResourceStore.java](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9wZXJzaXN0ZW5jZS9SZXNvdXJjZVN0b3JlLmphdmE=)
| `59% <0%> (ø)` | `25 <0> (?)` | |
| ... and [10
more](https://codecov.io/gh/apache/kylin/pull/197/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/197?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/197?src=pr&el=footer). Last
update
[ddfed27...ffe9757](https://codecov.io/gh/apache/kylin/pull/197?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace UUID.randomUUID with deterministic PRNG
> -----------------------------------------------
>
> Key: KYLIN-3317
> URL: https://issues.apache.org/jira/browse/KYLIN-3317
> Project: Kylin
> Issue Type: Task
> Components: Security
> Reporter: Ted Yu
> Assignee: jiatao.tao
> Priority: Major
> Fix For: v2.5.0
>
>
> Currently UUID.randomUUID is called in various places in the code base.
> * It is non-deterministic.
> * It uses a single secure random for UUID generation. This uses a single JVM
> wide lock, and this can lead to lock contention and other performance
> problems.
> We should move to something that is deterministic by using seeded PRNGs
> {code}
> new UUID(ThreadLocalRandom.current().nextLong(),
> ThreadLocalRandom.current().nextLong())
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
