[
https://issues.apache.org/jira/browse/KYLIN-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628627#comment-16628627
]
ASF GitHub Bot commented on KYLIN-3584:
---------------------------------------
codecov-io commented on issue #259: KYLIN-3584, KYLIN-3585
URL: https://github.com/apache/kylin/pull/259#issuecomment-424683333
# [Codecov](https://codecov.io/gh/apache/kylin/pull/259?src=pr&el=h1) Report
> Merging [#259](https://codecov.io/gh/apache/kylin/pull/259?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/34fd447c2f8b1852c530168e344d24f6efce4a3c?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/259?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #259 +/- ##
============================================
+ Coverage 21.11% 21.11% +<.01%
- Complexity 4404 4405 +1
============================================
Files 1087 1087
Lines 69878 69883 +5
Branches 10103 10105 +2
============================================
+ Hits 14756 14758 +2
- Misses 53723 53726 +3
Partials 1399 1399
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/259?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...g/apache/kylin/engine/spark/SparkFactDistinct.java](https://codecov.io/gh/apache/kylin/pull/259/diff?src=pr&el=tree#diff-ZW5naW5lLXNwYXJrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvc3BhcmsvU3BhcmtGYWN0RGlzdGluY3QuamF2YQ==)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/259/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh)
| `66.3% <0%> (-2.24%)` | `9 <0> (ø)` | |
|
[...e/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java](https://codecov.io/gh/apache/kylin/pull/259/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9hbGdvcml0aG0vQ3Vib2lkU3RhdHNVdGlsLmphdmE=)
| `87.09% <0%> (+0.28%)` | `26% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/259?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/259?src=pr&el=footer). Last
update
[34fd447...4454b1f](https://codecov.io/gh/apache/kylin/pull/259?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Incorrect lazy initialization of DefaultScheduler.INSTANCE
> ----------------------------------------------------------
>
> Key: KYLIN-3584
> URL: https://issues.apache.org/jira/browse/KYLIN-3584
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> Here is related code:
> {code}
> public static DefaultScheduler getInstance() {
> if (INSTANCE == null) {
> INSTANCE = createInstance();
> {code}
> The check against may not be effective.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
