[ 
https://issues.apache.org/jira/browse/KYLIN-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628633#comment-16628633
 ] 

ASF GitHub Bot commented on KYLIN-3584:
---------------------------------------

coveralls commented on issue #259: KYLIN-3584,  KYLIN-3585
URL: https://github.com/apache/kylin/pull/259#issuecomment-424684947
 
 
   ## Pull Request Test Coverage Report for [Build 
3661](https://coveralls.io/builds/19199226)
   
   * **0** of **4**   **(0.0%)**  changed or added relevant lines in **1** file 
are covered.
   * **1** unchanged line in **1** file lost coverage.
   * Overall coverage increased (+**0.001%**) to **23.123%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | 
[core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/19199226/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L54)
 | 0 | 4 | 0.0%
   <!-- | **Total:** | **0** | **4** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | 
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/algorithm/CuboidStatsUtil.java](https://coveralls.io/builds/19199226/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2Falgorithm%2FCuboidStatsUtil.java#L100)
 | 1 | 94.62% |
   <!-- | **Total:** | **1** |  | -->
   
   |  Totals | [![Coverage 
Status](https://coveralls.io/builds/19199226/badge)](https://coveralls.io/builds/19199226)
 |
   | :-- | --: |
   | Change from base [Build 3650](https://coveralls.io/builds/19173507): |  
0.001% |
   | Covered Lines: | 16159 |
   | Relevant Lines: | 69883 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Incorrect lazy initialization of DefaultScheduler.INSTANCE
> ----------------------------------------------------------
>
>                 Key: KYLIN-3584
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3584
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> Here is related code:
> {code}
>     public static DefaultScheduler getInstance() {
>         if (INSTANCE == null) {
>             INSTANCE = createInstance();
> {code}
> The check against may not be effective.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to