[
https://issues.apache.org/jira/browse/KYLIN-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630395#comment-16630395
]
ASF GitHub Bot commented on KYLIN-3586:
---------------------------------------
yiming187 closed pull request #264: KYLIN-3586
URL: https://github.com/apache/kylin/pull/264
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/HBaseLookupRowEncoder.java
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/HBaseLookupRowEncoder.java
index 9ceabd2721..7269465992 100644
---
a/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/HBaseLookupRowEncoder.java
+++
b/storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/HBaseLookupRowEncoder.java
@@ -109,7 +109,7 @@ private void fillValues(Map<byte[], byte[]>
qualifierValMap, String[] result) {
for (Entry<byte[], byte[]> qualifierValEntry :
qualifierValMap.entrySet()) {
byte[] qualifier = qualifierValEntry.getKey();
byte[] value = qualifierValEntry.getValue();
- int valIdx = Integer.valueOf(Bytes.toString(qualifier));
+ int valIdx = Integer.parseInt(Bytes.toString(qualifier));
result[valIdx] = fromBytes(value);
}
}
diff --git a/tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java
b/tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java
index bc61f9475b..18ace6fae1 100644
--- a/tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java
+++ b/tool/src/main/java/org/apache/kylin/tool/JobInstanceExtractor.java
@@ -83,7 +83,7 @@ public JobInstanceExtractor() {
protected void executeExtract(OptionsHelper optionsHelper, File exportDir)
throws Exception {
String cube = optionsHelper.hasOption(OPTION_CUBE) ?
optionsHelper.getOptionValue(OPTION_CUBE) : null;
String project = optionsHelper.hasOption(OPTION_PROJECT) ?
optionsHelper.getOptionValue(OPTION_PROJECT) : null;
- int period = optionsHelper.hasOption(OPTION_PERIOD) ?
Integer.valueOf(optionsHelper.getOptionValue(OPTION_PERIOD)) : DEFAULT_PERIOD;
+ int period = optionsHelper.hasOption(OPTION_PERIOD) ?
Integer.parseInt(optionsHelper.getOptionValue(OPTION_PERIOD)) : DEFAULT_PERIOD;
long endTime = System.currentTimeMillis();
long startTime = endTime - period * 24 * 3600 * 1000; // time in Millis
diff --git a/tool/src/main/java/org/apache/kylin/tool/KylinLogExtractor.java
b/tool/src/main/java/org/apache/kylin/tool/KylinLogExtractor.java
index 80af352d95..a84345b67d 100644
--- a/tool/src/main/java/org/apache/kylin/tool/KylinLogExtractor.java
+++ b/tool/src/main/java/org/apache/kylin/tool/KylinLogExtractor.java
@@ -73,7 +73,7 @@ private void beforeExtract() {
protected void executeExtract(OptionsHelper optionsHelper, File exportDir)
throws Exception {
beforeExtract();
- int logPeriod = optionsHelper.hasOption(OPTION_LOG_PERIOD) ?
Integer.valueOf(optionsHelper.getOptionValue(OPTION_LOG_PERIOD)) :
DEFAULT_LOG_PERIOD;
+ int logPeriod = optionsHelper.hasOption(OPTION_LOG_PERIOD) ?
Integer.parseInt(optionsHelper.getOptionValue(OPTION_LOG_PERIOD)) :
DEFAULT_LOG_PERIOD;
if (logPeriod < 1) {
logger.warn("No logs to extract.");
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Boxing/unboxing to parse a primitive is suboptimal
> --------------------------------------------------
>
> Key: KYLIN-3586
> URL: https://issues.apache.org/jira/browse/KYLIN-3586
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Lijun Cao
> Priority: Major
> Fix For: v2.6.0
>
>
> An example is from HBaseLookupRowEncoder:
> {code}
> int valIdx = Integer.valueOf(Bytes.toString(qualifier));
> {code}
> valueOf returns an Integer object which would be unboxed and assigned to
> valIdx.
> Integer.parseInt() should be used instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
