[
https://issues.apache.org/jira/browse/KYLIN-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631256#comment-16631256
]
ASF GitHub Bot commented on KYLIN-3586:
---------------------------------------
coveralls commented on issue #269: KYLIN-3586 Fix eight primitive
boxing/unboxing problem.
URL: https://github.com/apache/kylin/pull/269#issuecomment-425297344
## Pull Request Test Coverage Report for [Build
3694](https://coveralls.io/builds/19239184)
* **10** of **58** **(17.24%)** changed or added relevant lines in **19**
files are covered.
* **2** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.001%**) to **23.166%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[tool/src/main/java/org/apache/kylin/tool/MrJobInfoExtractor.java](https://coveralls.io/builds/19239184/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FMrJobInfoExtractor.java#L154)
| 0 | 1 | 0.0%
|
[core-common/src/main/java/org/apache/kylin/common/util/MailService.java](https://coveralls.io/builds/19239184/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FMailService.java#L96)
| 0 | 1 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/metadata/filter/ExtractTupleFilter.java](https://coveralls.io/builds/19239184/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FExtractTupleFilter.java#L71)
| 0 | 1 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/metadata/filter/TimeConditionLiteralsReplacer.java](https://coveralls.io/builds/19239184/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FTimeConditionLiteralsReplacer.java#L85)
| 0 | 1 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/metadata/filter/UDF/MassInTupleFilter.java](https://coveralls.io/builds/19239184/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ffilter%2FUDF%2FMassInTupleFilter.java#L153)
| 0 | 1 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/metadata/tuple/Tuple.java](https://coveralls.io/builds/19239184/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Ftuple%2FTuple.java#L181)
| 0 | 1 | 0.0%
|
[storage-hbase/src/main/java/org/apache/kylin/storage/hbase/lookup/LookupTableHFilesBulkLoadJob.java](https://coveralls.io/builds/19239184/source?filename=storage-hbase%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstorage%2Fhbase%2Flookup%2FLookupTableHFilesBulkLoadJob.java#L64)
| 0 | 1 | 0.0%
|
[tool/src/main/java/org/apache/kylin/tool/MetadataCleanupJob.java](https://coveralls.io/builds/19239184/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FMetadataCleanupJob.java#L60)
| 0 | 1 | 0.0%
|
[source-kafka/src/main/java/org/apache/kylin/source/kafka/DefaultTimeParser.java](https://coveralls.io/builds/19239184/source?filename=source-kafka%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fkafka%2FDefaultTimeParser.java#L44)
| 0 | 1 | 0.0%
|
[server-base/src/main/java/org/apache/kylin/rest/job/HybridCubeCLI.java](https://coveralls.io/builds/19239184/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fjob%2FHybridCubeCLI.java#L119)
| 0 | 1 | 0.0%
<!-- | **Total:** | **10** | **58** | **17.24%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java](https://coveralls.io/builds/19239184/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmetadata%2Fcachesync%2FBroadcaster.java#L149)
| 1 | 57.71% |
|
[core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/19239184/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L64)
| 1 | 81.08% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/19239184)
|
| :-- | --: |
| Change from base [Build 3689](https://coveralls.io/builds/19227187): |
-0.001% |
| Covered Lines: | 16157 |
| Relevant Lines: | 69743 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Boxing/unboxing to parse a primitive is suboptimal
> --------------------------------------------------
>
> Key: KYLIN-3586
> URL: https://issues.apache.org/jira/browse/KYLIN-3586
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Lijun Cao
> Priority: Major
> Fix For: v2.6.0
>
>
> An example is from HBaseLookupRowEncoder:
> {code}
> int valIdx = Integer.valueOf(Bytes.toString(qualifier));
> {code}
> valueOf returns an Integer object which would be unboxed and assigned to
> valIdx.
> Integer.parseInt() should be used instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
