[jira] [Commented] (KYLIN-3586) Boxing/unboxing to parse a primitive is suboptimal

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/KYLIN-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641069#comment-16641069
 ] 

ASF GitHub Bot commented on KYLIN-3586:
---------------------------------------

codecov-io commented on issue #280: KYLIN-3586 Fix remaining boxing/unboxing 
problem
URL: https://github.com/apache/kylin/pull/280#issuecomment-427655739
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/280?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@eb01b69`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `14.28%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/280/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/280?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master     #280   +/-   ##
   =========================================
     Coverage          ?   21.28%           
     Complexity        ?     4437           
   =========================================
     Files             ?     1087           
     Lines             ?    69983           
     Branches          ?    10126           
   =========================================
     Hits              ?    14896           
     Misses            ?    53684           
     Partials          ?     1403
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/280?src=pr&el=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...in/java/org/apache/kylin/metadata/tuple/Tuple.java](https://codecov.io/gh/apache/kylin/pull/280/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWV0YWRhdGEvdHVwbGUvVHVwbGUuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...org/apache/kylin/common/debug/BackdoorToggles.java](https://codecov.io/gh/apache/kylin/pull/280/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9kZWJ1Zy9CYWNrZG9vclRvZ2dsZXMuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...c/main/java/org/apache/kylin/jdbc/KylinClient.java](https://codecov.io/gh/apache/kylin/pull/280/diff?src=pr&el=tree#diff-amRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vamRiYy9LeWxpbkNsaWVudC5qYXZh)
 | `67.83% <20%> (ø)` | `33 <0> (?)` | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/280?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/280?src=pr&el=footer). Last 
update 
[eb01b69...4bc2939](https://codecov.io/gh/apache/kylin/pull/280?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Boxing/unboxing to parse a primitive is suboptimal
> --------------------------------------------------
>
>                 Key: KYLIN-3586
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3586
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Lijun Cao
>            Priority: Major
>             Fix For: v2.6.0
>
>
> An example is from HBaseLookupRowEncoder:
> {code}
>             int valIdx = Integer.valueOf(Bytes.toString(qualifier));
> {code}
> valueOf returns an Integer object which would be unboxed and assigned to 
> valIdx.
> Integer.parseInt() should be used instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)