[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648956#comment-16648956
]
ASF GitHub Bot commented on KYLIN-3597:
---------------------------------------
shaofengshi commented on a change in pull request #288: KYLIN-3597 Improve code
smell
URL: https://github.com/apache/kylin/pull/288#discussion_r224960913
##########
File path: core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java
##########
@@ -100,6 +100,9 @@ public static CubeManager getInstance(KylinConfig config) {
return config.getManager(CubeManager.class);
}
+ private static final String FOR_CUBE = "For cube ";
+ private static final String SEGMENT = ", segment ";
Review comment:
I don't think this worth to declare.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix sonar reported static code issues
> -------------------------------------
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
> Issue Type: Improvement
> Components: Others
> Reporter: Shaofeng SHI
> Priority: Major
> Fix For: v2.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
