[
https://issues.apache.org/jira/browse/KYLIN-3597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649190#comment-16649190
]
ASF GitHub Bot commented on KYLIN-3597:
---------------------------------------
codecov-io commented on issue #288: KYLIN-3597 Improve code smell
URL: https://github.com/apache/kylin/pull/288#issuecomment-429588453
# [Codecov](https://codecov.io/gh/apache/kylin/pull/288?src=pr&el=h1) Report
> Merging [#288](https://codecov.io/gh/apache/kylin/pull/288?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/kylin/commit/fdafecc23a34e1b245dbe409cfd2fc1984717c55?src=pr&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `3.26%`.
[](https://codecov.io/gh/apache/kylin/pull/288?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #288 +/- ##
===========================================
+ Coverage 21.29% 21.3% +0.01%
Complexity 4442 4442
===========================================
Files 1087 1087
Lines 69953 69966 +13
Branches 10107 10107
===========================================
+ Hits 14894 14907 +13
- Misses 53650 53656 +6
+ Partials 1409 1403 -6
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/288?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...age/hbase/lookup/LookupTableHFilesBulkLoadJob.java](https://codecov.io/gh/apache/kylin/pull/288/diff?src=pr&el=tree#diff-c3RvcmFnZS1oYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RvcmFnZS9oYmFzZS9sb29rdXAvTG9va3VwVGFibGVIRmlsZXNCdWxrTG9hZEpvYi5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/288/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
| `14.68% <2.77%> (ø)` | `36 <2> (ø)` | :arrow_down: |
|
[...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/288/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=)
| `39.71% <5.26%> (-0.96%)` | `42 <0> (ø)` | |
|
[...lin/dict/lookup/cache/RocksDBLookupTableCache.java](https://codecov.io/gh/apache/kylin/pull/288/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGVDYWNoZS5qYXZh)
| `76.68% <0%> (+0.51%)` | `27% <0%> (ø)` | :arrow_down: |
|
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/288/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
| `70.21% <0%> (+3.64%)` | `7% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/288?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/288?src=pr&el=footer). Last
update
[fdafecc...45af68f](https://codecov.io/gh/apache/kylin/pull/288?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix sonar reported static code issues
> -------------------------------------
>
> Key: KYLIN-3597
> URL: https://issues.apache.org/jira/browse/KYLIN-3597
> Project: Kylin
> Issue Type: Improvement
> Components: Others
> Reporter: Shaofeng SHI
> Priority: Major
> Fix For: v2.6.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
