[
https://issues.apache.org/jira/browse/KYLIN-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jiatao.tao updated KYLIN-3630:
------------------------------
Description:
Like in code org.apache.kylin.measure.raw.RawMeasureType#RawMeasureType, we can
see that both funcName and dataType are use, and this can be remove cuz
there's no constraint on its constructor.
And after we done that, we can mo easily test MeasureType without passing in
meaningless args.
!screenshot-1.png!
Like codes in org.apache.kylin.measure.dim.DimCountDistinctMeasureType
!image-2018-10-14-18-56-29-010.png!
was: !image-2018-10-14-18-56-29-010.png!
> remove unused fields in the implementations of MeasureType
> ----------------------------------------------------------
>
> Key: KYLIN-3630
> URL: https://issues.apache.org/jira/browse/KYLIN-3630
> Project: Kylin
> Issue Type: Improvement
> Reporter: jiatao.tao
> Assignee: jiatao.tao
> Priority: Minor
> Attachments: image-2018-10-14-18-56-29-010.png, screenshot-1.png
>
>
> Like in code org.apache.kylin.measure.raw.RawMeasureType#RawMeasureType, we
> can see that both funcName and dataType are use, and this can be remove cuz
> there's no constraint on its constructor.
> And after we done that, we can mo easily test MeasureType without passing in
> meaningless args.
> !screenshot-1.png!
> Like codes in org.apache.kylin.measure.dim.DimCountDistinctMeasureType
> !image-2018-10-14-18-56-29-010.png!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
