[
https://issues.apache.org/jira/browse/KYLIN-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shaofeng SHI updated KYLIN-3630:
--------------------------------
Fix Version/s: v2.6.0
Summary: Remove unused fields in the implementations of MeasureType
(was: remove unused fields in the implementations of MeasureType)
> Remove unused fields in the implementations of MeasureType
> ----------------------------------------------------------
>
> Key: KYLIN-3630
> URL: https://issues.apache.org/jira/browse/KYLIN-3630
> Project: Kylin
> Issue Type: Improvement
> Reporter: jiatao.tao
> Assignee: jiatao.tao
> Priority: Minor
> Fix For: v2.6.0
>
>
> In code RawMeasureType#RawMeasureType, we can see that both funcName and
> dataType are use, and this can be remove cuz there's no constraint on its
> constructor.
> {code:java}
> @SuppressWarnings("unused")
> private final DataType dataType;
> public RawMeasureType(String funcName, DataType dataType) {
> this.dataType = dataType;
> }
> {code}
> And after we done that, we can more easily test MeasureType without passing
> in meaningless args(AggregatorMemEstimateTest#112).
> Like codes in org.apache.kylin.measure.dim.DimCountDistinctMeasureType, other
> implementations can be cleaner.
> {code:java}
> @Override
> public MeasureType<Object> createMeasureType(String funcName,
> DataType dataType) {
> return new DimCountDistinctMeasureType();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
