[
https://issues.apache.org/jira/browse/KYLIN-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649352#comment-16649352
]
ASF GitHub Bot commented on KYLIN-3630:
---------------------------------------
codecov-io commented on issue #289: KYLIN-3630, remove unused fields in the
implementations of MeasureType
URL: https://github.com/apache/kylin/pull/289#issuecomment-429619135
# [Codecov](https://codecov.io/gh/apache/kylin/pull/289?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@ec10114`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/kylin/pull/289?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #289 +/- ##
========================================
Coverage ? 21.3%
Complexity ? 4441
========================================
Files ? 1087
Lines ? 69953
Branches ? 10108
========================================
Hits ? 14906
Misses ? 53644
Partials ? 1403
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/289?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...sure/extendedcolumn/ExtendedColumnMeasureType.java](https://codecov.io/gh/apache/kylin/pull/289/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9leHRlbmRlZGNvbHVtbi9FeHRlbmRlZENvbHVtbk1lYXN1cmVUeXBlLmphdmE=)
| `30.27% <100%> (ø)` | `5 <1> (?)` | |
|
[...org/apache/kylin/measure/topn/TopNMeasureType.java](https://codecov.io/gh/apache/kylin/pull/289/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS90b3BuL1RvcE5NZWFzdXJlVHlwZS5qYXZh)
| `4.5% <100%> (ø)` | `3 <1> (?)` | |
|
[...apache/kylin/measure/bitmap/BitmapMeasureType.java](https://codecov.io/gh/apache/kylin/pull/289/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9iaXRtYXAvQml0bWFwTWVhc3VyZVR5cGUuamF2YQ==)
| `19.6% <100%> (ø)` | `4 <1> (?)` | |
|
[...a/org/apache/kylin/measure/raw/RawMeasureType.java](https://codecov.io/gh/apache/kylin/pull/289/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9yYXcvUmF3TWVhc3VyZVR5cGUuamF2YQ==)
| `9.37% <100%> (ø)` | `3 <1> (?)` | |
|
[...org/apache/kylin/measure/hllc/HLLCMeasureType.java](https://codecov.io/gh/apache/kylin/pull/289/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9obGxjL0hMTENNZWFzdXJlVHlwZS5qYXZh)
| `65% <100%> (ø)` | `5 <1> (?)` | |
|
[...ylin/measure/percentile/PercentileMeasureType.java](https://codecov.io/gh/apache/kylin/pull/289/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9wZXJjZW50aWxlL1BlcmNlbnRpbGVNZWFzdXJlVHlwZS5qYXZh)
| `55% <100%> (ø)` | `4 <1> (?)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/289?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/289?src=pr&el=footer). Last
update
[ec10114...f32c098](https://codecov.io/gh/apache/kylin/pull/289?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> remove unused fields in the implementations of MeasureType
> ----------------------------------------------------------
>
> Key: KYLIN-3630
> URL: https://issues.apache.org/jira/browse/KYLIN-3630
> Project: Kylin
> Issue Type: Improvement
> Reporter: jiatao.tao
> Assignee: jiatao.tao
> Priority: Minor
>
> In code RawMeasureType#RawMeasureType, we can see that both funcName and
> dataType are use, and this can be remove cuz there's no constraint on its
> constructor.
> {code:java}
> @SuppressWarnings("unused")
> private final DataType dataType;
> public RawMeasureType(String funcName, DataType dataType) {
> this.dataType = dataType;
> }
> {code}
> And after we done that, we can more easily test MeasureType without passing
> in meaningless args(AggregatorMemEstimateTest#112).
> Like codes in org.apache.kylin.measure.dim.DimCountDistinctMeasureType, other
> implementations can be cleaner.
> {code:java}
> @Override
> public MeasureType<Object> createMeasureType(String funcName,
> DataType dataType) {
> return new DimCountDistinctMeasureType();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
