[ https://issues.apache.org/jira/browse/KYLIN-3630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649370#comment-16649370 ]
ASF subversion and git services commented on KYLIN-3630: -------------------------------------------------------- Commit 50f175892a558d40d645501745c9ab7d060fa0f6 in kylin's branch refs/heads/master from tttMelody [ https://gitbox.apache.org/repos/asf?p=kylin.git;h=50f1758 ] KYLIN-3630, remove unused fields in the implementations of MeasureType > remove unused fields in the implementations of MeasureType > ---------------------------------------------------------- > > Key: KYLIN-3630 > URL: https://issues.apache.org/jira/browse/KYLIN-3630 > Project: Kylin > Issue Type: Improvement > Reporter: jiatao.tao > Assignee: jiatao.tao > Priority: Minor > > In code RawMeasureType#RawMeasureType, we can see that both funcName and > dataType are use, and this can be remove cuz there's no constraint on its > constructor. > {code:java} > @SuppressWarnings("unused") > private final DataType dataType; > public RawMeasureType(String funcName, DataType dataType) { > this.dataType = dataType; > } > {code} > And after we done that, we can more easily test MeasureType without passing > in meaningless args(AggregatorMemEstimateTest#112). > Like codes in org.apache.kylin.measure.dim.DimCountDistinctMeasureType, other > implementations can be cleaner. > {code:java} > @Override > public MeasureType<Object> createMeasureType(String funcName, > DataType dataType) { > return new DimCountDistinctMeasureType(); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)