[
https://issues.apache.org/jira/browse/KYLIN-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655087#comment-16655087
]
ASF GitHub Bot commented on KYLIN-3635:
---------------------------------------
codecov-io commented on issue #294: KYLIN-3635 Percentile calculation on Spark
engine is wrong
URL: https://github.com/apache/kylin/pull/294#issuecomment-430976873
# [Codecov](https://codecov.io/gh/apache/kylin/pull/294?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@2ab720d`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/294?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #294 +/- ##
========================================
Coverage ? 21.3%
Complexity ? 4442
========================================
Files ? 1087
Lines ? 69969
Branches ? 10108
========================================
Hits ? 14909
Misses ? 53658
Partials ? 1402
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/294?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...ylin/measure/percentile/PercentileMeasureType.java](https://codecov.io/gh/apache/kylin/pull/294/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS9wZXJjZW50aWxlL1BlcmNlbnRpbGVNZWFzdXJlVHlwZS5qYXZh)
| `50% <0%> (ø)` | `4 <0> (?)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/294?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/294?src=pr&el=footer). Last
update
[2ab720d...6b2ae48](https://codecov.io/gh/apache/kylin/pull/294?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Percentile calculation on Spark engine is wrong
> -----------------------------------------------
>
> Key: KYLIN-3635
> URL: https://issues.apache.org/jira/browse/KYLIN-3635
> Project: Kylin
> Issue Type: Bug
> Affects Versions: v2.3.0, v2.3.1, v2.4.0, v2.3.2, v2.4.1, v2.5.0
> Reporter: Shaofeng SHI
> Priority: Major
>
> As titled; Received reporting that percentile result is wrong when using
> Spark engine. Checked the code and found the object was reused and not reset,
> the problem won't happen on normal MR as it would be serialized before next
> call, but would be a problem on Spark, as the object was cached in-memory and
> be serialized later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
