[
https://issues.apache.org/jira/browse/KYLIN-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665152#comment-16665152
]
ASF GitHub Bot commented on KYLIN-3635:
---------------------------------------
coveralls commented on issue #316: KYLIN-3635, make a stronger constraint about
implementing method reset().
URL: https://github.com/apache/kylin/pull/316#issuecomment-433402739
## Pull Request Test Coverage Report for [Build
3814](https://coveralls.io/builds/19741079)
* **0** of **4** **(0.0%)** changed or added relevant lines in **4**
files are covered.
* **5** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.004%**) to **23.299%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
|
[core-metadata/src/main/java/org/apache/kylin/measure/basic/BigDecimalIngester.java](https://coveralls.io/builds/19741079/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fbasic%2FBigDecimalIngester.java#L45)
| 0 | 1 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/measure/extendedcolumn/ExtendedColumnMeasureType.java](https://coveralls.io/builds/19741079/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fextendedcolumn%2FExtendedColumnMeasureType.java#L245)
| 0 | 1 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/measure/raw/RawMeasureType.java](https://coveralls.io/builds/19741079/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Fraw%2FRawMeasureType.java#L129)
| 0 | 1 | 0.0%
|
[core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java](https://coveralls.io/builds/19741079/source?filename=core-metadata%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fmeasure%2Ftopn%2FTopNMeasureType.java#L168)
| 0 | 1 | 0.0%
<!-- | **Total:** | **0** | **4** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19741079/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L439)
| 5 | 77.81% |
<!-- | **Total:** | **5** | | -->
| Totals | [](https://coveralls.io/builds/19741079)
|
| :-- | --: |
| Change from base [Build 3810](https://coveralls.io/builds/19711495): |
-0.004% |
| Covered Lines: | 16314 |
| Relevant Lines: | 70019 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Percentile calculation on Spark engine is wrong
> -----------------------------------------------
>
> Key: KYLIN-3635
> URL: https://issues.apache.org/jira/browse/KYLIN-3635
> Project: Kylin
> Issue Type: Bug
> Components: Spark Engine
> Affects Versions: v2.3.0, v2.3.1, v2.4.0, v2.3.2, v2.4.1, v2.5.0
> Reporter: Shaofeng SHI
> Assignee: Shaofeng SHI
> Priority: Major
> Fix For: v2.4.2, v2.5.1
>
>
> As titled; Received reporting that percentile result is wrong when using
> Spark engine. Checked the code and found the object was reused and not reset,
> the problem won't happen on normal MR as it would be serialized before next
> call, but would be a problem on Spark, as the object was cached in-memory and
> be serialized later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
