[
https://issues.apache.org/jira/browse/KYLIN-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16658232#comment-16658232
]
ASF GitHub Bot commented on KYLIN-3620:
---------------------------------------
coveralls edited a comment on issue #302: KYLIN-3620 resolve "--" is treated as
comment marker between singe qu…
URL: https://github.com/apache/kylin/pull/302#issuecomment-431662713
## Pull Request Test Coverage Report for [Build
3790](https://coveralls.io/builds/19640075)
* **1** of **1** **(100.0%)** changed or added relevant line in **1**
file are covered.
* **6** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.001%**) to **23.318%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
|
[server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/19640075/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72)
| 1 | 47.62% |
|
[core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/19640075/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124)
| 2 | 68.46% |
|
[core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/19640075/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449)
| 3 | 78.42% |
<!-- | **Total:** | **6** | | -->
| Totals | [](https://coveralls.io/builds/19640075)
|
| :-- | --: |
| Change from base [Build 3782](https://coveralls.io/builds/19627842): |
-0.001% |
| Covered Lines: | 16320 |
| Relevant Lines: | 69989 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> "--" should not be a comment marker use between single quotes in SQL
> --------------------------------------------------------------------
>
> Key: KYLIN-3620
> URL: https://issues.apache.org/jira/browse/KYLIN-3620
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: v2.4.1
> Reporter: Scott Fan
> Assignee: Lijun Cao
> Priority: Major
> Fix For: v2.6.0
>
>
> Hi,
> When I exec a SQL like below, there was an error.
> SELECT * FROM TABLEA WHERE NAME='Jason--Arthur'
> Seems like KYLIN use the – as a comment marker.
> It should not be that between single quotes, I think.
>
> Even I send a REST POST contains SQL like that, or do an ODBC query, there
> was an error too.
> You may tell me that I can use a \ as escape, but I can't change the SQL
> generated by BI tools like tableau.
> Thanks
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
