[
https://issues.apache.org/jira/browse/KYLIN-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660721#comment-16660721
]
ASF GitHub Bot commented on KYLIN-3620:
---------------------------------------
codecov-io commented on issue #302: KYLIN-3620 resolve "--" is treated as
comment marker between singe qu…
URL: https://github.com/apache/kylin/pull/302#issuecomment-432266197
# [Codecov](https://codecov.io/gh/apache/kylin/pull/302?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base
(`master@8b51d4a`). [Click here to learn what that
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/kylin/pull/302?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #302 +/- ##
=========================================
Coverage ? 21.32%
Complexity ? 4446
=========================================
Files ? 1089
Lines ? 69996
Branches ? 10098
=========================================
Hits ? 14925
Misses ? 53668
Partials ? 1403
```
| [Impacted
Files](https://codecov.io/gh/apache/kylin/pull/302?src=pr&el=tree) | Coverage Δ
| Complexity Δ | |
|---|---|---|---|
|
[...in/java/org/apache/kylin/query/util/QueryUtil.java](https://codecov.io/gh/apache/kylin/pull/302/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUXVlcnlVdGlsLmphdmE=)
| `58.44% <100%> (ø)` | `19 <2> (?)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/kylin/pull/302?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/kylin/pull/302?src=pr&el=footer). Last
update
[8b51d4a...f5e89c2](https://codecov.io/gh/apache/kylin/pull/302?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> "--" should not be a comment marker use between single quotes in SQL
> --------------------------------------------------------------------
>
> Key: KYLIN-3620
> URL: https://issues.apache.org/jira/browse/KYLIN-3620
> Project: Kylin
> Issue Type: Bug
> Components: Query Engine
> Affects Versions: v2.4.1
> Reporter: Scott Fan
> Assignee: Lijun Cao
> Priority: Major
> Fix For: v2.6.0
>
>
> Hi,
> When I exec a SQL like below, there was an error.
> SELECT * FROM TABLEA WHERE NAME='Jason--Arthur'
> Seems like KYLIN use the – as a comment marker.
> It should not be that between single quotes, I think.
>
> Even I send a REST POST contains SQL like that, or do an ODBC query, there
> was an error too.
> You may tell me that I can use a \ as escape, but I can't change the SQL
> generated by BI tools like tableau.
> Thanks
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
