shaofengshi commented on a change in pull request #316: KYLIN-3635, make a
stronger constraint about implementing method reset().
URL: https://github.com/apache/kylin/pull/316#discussion_r228788317
##########
File path:
core-metadata/src/main/java/org/apache/kylin/measure/MeasureIngester.java
##########
@@ -43,9 +43,7 @@
abstract public V valueOf(String[] values, MeasureDesc measureDesc,
Map<TblColRef, Dictionary<String>> dictionaryMap);
- public void reset() {
-
- }
+ abstract public void reset();
Review comment:
Jiatao, it is good to make this method as abstract; If you can add some
comment on this method to tell the developer why this method is so important,
that would be great.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
