Aaaaaaron commented on a change in pull request #316: KYLIN-3635, make a
stronger constraint about implementing method reset().
URL: https://github.com/apache/kylin/pull/316#discussion_r228788582
##########
File path:
core-metadata/src/main/java/org/apache/kylin/measure/MeasureIngester.java
##########
@@ -43,9 +43,7 @@
abstract public V valueOf(String[] values, MeasureDesc measureDesc,
Map<TblColRef, Dictionary<String>> dictionaryMap);
- public void reset() {
-
- }
+ abstract public void reset();
Review comment:
Thanks, Shaofeng, Pretty good advice!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
