[
https://issues.apache.org/jira/browse/KYLIN-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666784#comment-16666784
]
ASF GitHub Bot commented on KYLIN-3635:
---------------------------------------
shaofengshi closed pull request #316: KYLIN-3635, make a stronger constraint
about implementing method reset().
URL: https://github.com/apache/kylin/pull/316
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/core-metadata/src/main/java/org/apache/kylin/measure/MeasureIngester.java
b/core-metadata/src/main/java/org/apache/kylin/measure/MeasureIngester.java
index ed2cb02e59..b48acf0862 100644
--- a/core-metadata/src/main/java/org/apache/kylin/measure/MeasureIngester.java
+++ b/core-metadata/src/main/java/org/apache/kylin/measure/MeasureIngester.java
@@ -43,9 +43,9 @@
abstract public V valueOf(String[] values, MeasureDesc measureDesc,
Map<TblColRef, Dictionary<String>> dictionaryMap);
- public void reset() {
-
- }
+ // Be attention with this, do remember resetting objects if you init in
your implementation.
+ // See more details in KYLIN-3635.
+ abstract public void reset();
public V reEncodeDictionary(V value, MeasureDesc measureDesc,
Map<TblColRef, Dictionary<String>> oldDicts, Map<TblColRef, Dictionary<String>>
newDicts) {
throw new UnsupportedOperationException();
diff --git
a/core-metadata/src/main/java/org/apache/kylin/measure/basic/BigDecimalIngester.java
b/core-metadata/src/main/java/org/apache/kylin/measure/basic/BigDecimalIngester.java
index c7541abb04..5194606b11 100644
---
a/core-metadata/src/main/java/org/apache/kylin/measure/basic/BigDecimalIngester.java
+++
b/core-metadata/src/main/java/org/apache/kylin/measure/basic/BigDecimalIngester.java
@@ -38,4 +38,9 @@ public BigDecimal valueOf(String[] values, MeasureDesc
measureDesc, Map<TblColRe
else
return new BigDecimal(values[0]);
}
+
+ @Override
+ public void reset() {
+
+ }
}
diff --git
a/core-metadata/src/main/java/org/apache/kylin/measure/extendedcolumn/ExtendedColumnMeasureType.java
b/core-metadata/src/main/java/org/apache/kylin/measure/extendedcolumn/ExtendedColumnMeasureType.java
index 4c20ef3fe2..ed5a2134a4 100644
---
a/core-metadata/src/main/java/org/apache/kylin/measure/extendedcolumn/ExtendedColumnMeasureType.java
+++
b/core-metadata/src/main/java/org/apache/kylin/measure/extendedcolumn/ExtendedColumnMeasureType.java
@@ -238,6 +238,11 @@ public ByteArray valueOf(String[] values, MeasureDesc
measureDesc,
truncateWhenUTF8(literal,
dataType.getPrecision()).getBytes(StandardCharsets.UTF_8));
}
}
+
+ @Override
+ public void reset() {
+
+ }
};
}
diff --git
a/core-metadata/src/main/java/org/apache/kylin/measure/raw/RawMeasureType.java
b/core-metadata/src/main/java/org/apache/kylin/measure/raw/RawMeasureType.java
index e9f1c82c45..7dc8eccc8a 100644
---
a/core-metadata/src/main/java/org/apache/kylin/measure/raw/RawMeasureType.java
+++
b/core-metadata/src/main/java/org/apache/kylin/measure/raw/RawMeasureType.java
@@ -123,6 +123,11 @@ public boolean isMemoryHungry() {
return valueList;
}
+ @Override
+ public void reset() {
+
+ }
+
//merge measure dictionary
@Override
public List<ByteArray> reEncodeDictionary(List<ByteArray> value,
MeasureDesc measureDesc, Map<TblColRef, Dictionary<String>> oldDicts,
Map<TblColRef, Dictionary<String>> newDicts) {
diff --git
a/core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java
b/core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java
index 9b6ff0ac20..d7b1bd7382 100644
---
a/core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java
+++
b/core-metadata/src/main/java/org/apache/kylin/measure/topn/TopNMeasureType.java
@@ -162,6 +162,11 @@ public boolean isMemoryHungry() {
return topNCounter;
}
+ @Override
+ public void reset() {
+
+ }
+
@Override
public TopNCounter<ByteArray>
reEncodeDictionary(TopNCounter<ByteArray> value, MeasureDesc measureDesc,
Map<TblColRef, Dictionary<String>> oldDicts,
Map<TblColRef, Dictionary<String>> newDicts) {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Percentile calculation on Spark engine is wrong
> -----------------------------------------------
>
> Key: KYLIN-3635
> URL: https://issues.apache.org/jira/browse/KYLIN-3635
> Project: Kylin
> Issue Type: Bug
> Components: Spark Engine
> Affects Versions: v2.3.0, v2.3.1, v2.4.0, v2.3.2, v2.4.1, v2.5.0
> Reporter: Shaofeng SHI
> Assignee: Shaofeng SHI
> Priority: Major
> Fix For: v2.4.2, v2.5.1
>
>
> As titled; Received reporting that percentile result is wrong when using
> Spark engine. Checked the code and found the object was reused and not reset,
> the problem won't happen on normal MR as it would be serialized before next
> call, but would be a problem on Spark, as the object was cached in-memory and
> be serialized later.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
